Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Temporarily Disabled Preset Confirm in New Campaign Dialog #5175

Merged

Conversation

IllianiCBT
Copy link
Collaborator

As per title. Customize preset is still available. This functionality was set up to enable easy testing of new features and is feature incomplete without the rest of Campaign Options IIC. Once 50.01 has shipped this option will be re-enabled.

As per title. Customize preset is still available. This functionality was set up to enable easy testing of new features and is feature incomplete without the rest of Campaign Options IIC. Once 50.01 has shipped this option will be re-enabled.
@IllianiCBT IllianiCBT added the Campaign Options Relates to, or includes, campaign option changes label Nov 6, 2024
@IllianiCBT IllianiCBT self-assigned this Nov 6, 2024
@codecov-commenter
Copy link

codecov-commenter commented Nov 6, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 10.52%. Comparing base (2b3d042) to head (67a7b38).
Report is 35 commits behind head on master.

Additional details and impacted files
@@             Coverage Diff              @@
##             master    #5175      +/-   ##
============================================
- Coverage     10.52%   10.52%   -0.01%     
+ Complexity     6042     6039       -3     
============================================
  Files           956      956              
  Lines        134346   134349       +3     
  Branches      19514    19515       +1     
============================================
- Hits          14145    14139       -6     
- Misses       118851   118855       +4     
- Partials       1350     1355       +5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@IllianiCBT IllianiCBT merged commit 3a92f71 into MegaMek:master Nov 7, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Campaign Options Relates to, or includes, campaign option changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants